Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only resolve target type in try_coerce in new solver #114648

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Only resolve target type in try_coerce in new solver #114648

merged 1 commit into from
Aug 10, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 9, 2023 •
edited
Loading

Only needed in new solver, seems to affect perf in old solver.

cc #114604/#114594

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 9, 2023
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 9, 2023
@bors
Copy link
Contributor

bors commented Aug 9, 2023

⌛ Trying commit b2e95ad62b2f32f13f18feeee6e5799c5b9d9093 with merge 52480ae4b2feca7f8ed2c5b46c0be89884f6f456...

@compiler-errors compiler-errors mentioned this pull request Aug 9, 2023
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 9, 2023

☀️ Try build successful - checks-actions
Build commit: 52480ae4b2feca7f8ed2c5b46c0be89884f6f456 (52480ae4b2feca7f8ed2c5b46c0be89884f6f456)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (52480ae4b2feca7f8ed2c5b46c0be89884f6f456): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.8% [-2.0%, -1.6%] 2
Improvements ✅
(secondary)		 -0.9% [-1.1%, -0.6%] 4
All ❌✅ (primary) -1.8% [-2.0%, -1.6%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.9% [1.7%, 2.1%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) 1.9% [1.7%, 2.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.915s -> 631.09s (-0.29%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 9, 2023
@compiler-errors compiler-errors changed the title [perf] Investigate perf regression in #114604/#114594 Only resolve target type in try_coerce in new solver Aug 9, 2023
@compiler-errors compiler-errors marked this pull request as ready for review August 9, 2023 17:02
@compiler-errors
Copy link
Member Author

r? @lcnr or @lqd

@lqd
Copy link
Member

lqd commented Aug 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2023

📌 Commit 214d78d has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2023
@lqd lqd mentioned this pull request Aug 9, 2023
Merged
@bors
Copy link
Contributor

bors commented Aug 9, 2023

⌛ Testing commit 214d78d with merge 622d88d1a9468de9f422d7dd9743f13ef96047b9...

@bors
Copy link
Contributor

bors commented Aug 9, 2023

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 622d88d1a9468de9f422d7dd9743f13ef96047b9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2023
@bors
Copy link
Contributor

bors commented Aug 9, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@lqd
Copy link
Member

lqd commented Aug 9, 2023

@bors retry

@rust-timer

This comment was marked as duplicate.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 10, 2023

⌛ Testing commit 214d78d with merge fd16988...

@bors
Copy link
Contributor

bors commented Aug 10, 2023

☀️ Test successful - checks-actions
Approved by: lqd
Pushing fd16988 to master...

@bors bors merged commit fd16988 into rust-lang:master Aug 10, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd16988): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.7% [-1.8%, -1.6%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-1.8%, 1.0%] 3

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.758s -> 633.485s (-0.04%)

@rustbot rustbot added the perf-regression Performance regression. label Aug 10, 2023
@compiler-errors compiler-errors deleted the perf-114604 branch August 11, 2023 20:13
@pnkfelix
Copy link
Member

Visiting for weekly performance triage

  • This was specifically added to undo regressions flagged in PR Rollup of 7 pull requests #114604
  • it did indeed undo the big changes: e.g. cranelift-codegen-0.82.1 had regressed by {2%, 1.7%}, and this improved it back by {-1.84%, -1.59%}
  • likewise cargo-0.60.0 had improved by -0.93%, and this regressed it back by 0.99%. (I.e. we returned to prior status quo.)
  • some other effects were not addressed by this PR, but they are all minor.
  • marking as triaged.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 14, 2023
@GrigorenkoPV GrigorenkoPV mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
8 participants
@compiler-errors @rust-timer @bors @rust-log-analyzer @lqd @pnkfelix @lcnr @rustbot